-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1608 Create column filtering for tables and add filters to Data Submission List table #476
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
It looks like the run time for Jest in CI has jumped ~10s in this PR. If you added a lot of tests that use async with waitFor then this is probably to be expected, especially since I limited the number of tests that can run in parallel (#454). Locally, however, the run time has only increased like 1 second at most (approx. 35s total). Anecdotally, Jest has always randomly bogged down for me locally, but it disappears usually after rebooting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions and suggestions are annotated below. In general, most of them are optional.
As a side note, not directly related to this PR, the GenericTable does a lot of rerendering during the initial display of rows and subsequently causes all of the nested components to rerender with it. At some point, we should attempt to stabilize it more with stronger memoization for props/etc. Just a potential QoL improvement for the future (maybe 3.2.0). |
…two numbers, also added test coverage
…lso, prevent form from ever accepting the values if below
…il it reaches at least 3 characters
Agreed, unfortunately I let it get out of hand. The table is becoming quite a mess. It is in need of some strong refactoring, but will be quite the lift. Fixing the re-rendering problem is definitely a good start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Skipping updating the branch, only minor changes in 3.1.0. |
Overview
Added ability to toggle column visibility on Data Submission List table. Also added additional filters to narrow down search.
Change Details (Specifics)
Note
Sorting for list of Data Commons and Submitters will be done on the BE.
Related Ticket(s)
CRDCDH-1608 (Task)
CRDCDH-1586 (User Story)